Reversed a few tight loops#151
Open
mlsomers wants to merge 1 commit intoerikkaashoek:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An old optimization trick: Remove the comparison from the loop.
For example:
The comparison
i<bwill be done a thousand times.In assembly it would look like:
Replace that code with:
In assemby the
i!=0comparison looks likeWhich (depending on the compiler, processor and branch prediction) usually results in a faster loop.
Note that the loop does not include zero, so the [0] item will have to be done separately.
Disclaimer: I could not compile, or test these changes, still figuring out how to set this up, I just applied the technique to some random places hoping I would hit a significant one :-)
It is not always worthwhile. Small static loops would be unwind-ed by the compiler. If the stuff inside the loop is extensive then the difference would be insignificant. It usually helps with copying buffers or things like moving the waterfall one pixel down (could not find that part though).
Hope this helps a little, even if it only extends battery life when the processor is not a bottleneck.